Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload: 403 results in interesting error message #94

Closed
tschmidtb51 opened this issue Apr 7, 2022 · 4 comments
Closed

Upload: 403 results in interesting error message #94

tschmidtb51 opened this issue Apr 7, 2022 · 4 comments
Assignees
@JanHoefelmeyer
Labels
csaf_uploader

Comments

@tschmidtb51
Copy link
Collaborator

tschmidtb51 commented Apr 7, 2022 •
edited
Loading

When trying to upload without the password, it results correctly in 403. But the message seems a little bit weird:

Upload failed: 403 Forbidden
error: invalid character 'F' looking for beginning of value

I guess

csaf_distribution/cmd/csaf_uploader/main.go

Lines 289 to 291 in 530a027

if resp.StatusCode != http.StatusOK {
log.Printf("Upload failed: %s\n", resp.Status)
}
should exit the function if a 403 occurs...
@bernhardreiter
Copy link
Collaborator

Yes the error handling can be improved in this case.

Fadiabb pushed a commit that referenced this issue May 23, 2022
Handle "403" error (provider)
44b138a 
	* #94
@bernhardreiter
Copy link
Collaborator

We'll plan some code cleanup next.

@bernhardreiter bernhardreiter mentioned this issue Jul 7, 2022
Closed
@s-l-teichmann
Copy link
Collaborator

This should be solved with PR #247

@JanHoefelmeyer
Copy link
Collaborator

It's indeed solved by #247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JanHoefelmeyer JanHoefelmeyer

Labels
csaf_uploader
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@s-l-teichmann @bernhardreiter @tschmidtb51 @JanHoefelmeyer