Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Language conversion #84

Open
tschmidtb51 opened this issue Mar 17, 2022 · 6 comments
Open

Implement Language conversion #84

tschmidtb51 opened this issue Mar 17, 2022 · 6 comments

Comments

@tschmidtb51
Copy link
Collaborator

The conformance clause 5: CVRF CSAF converter states the conversion rule for the document language:

/document/lang: If one or more CVRF element containing an xml:lang attribute exist and contain the exact same value, the CVRF CSAF converter converts this value into lang. If the values of xml:lang attributes are not equal, the CVRF CSAF converter outputs a warning that the language could not be determined and possibly a document with multiple languages was produced. In addition, it SHOULD also present all values of xml:lang attributes as a set in the warning.

This must be implemented in the CVRF-CSAF converter to be conformant.

@tschmidtb51 tschmidtb51 added the bug Something isn't working label Mar 17, 2022
@cgi1
Copy link
Contributor

cgi1 commented Mar 17, 2022

Dear @tschmidtb51,

going back to the beginning of the project we defined in #4 how the conformance clause 5 has been specified for the project. You actually added the /document/lang requirement way later as we already finished this area. We do not consider this as a bug, as the specification has been implemented as agreed during kick off.

@cgi1 cgi1 removed the bug Something isn't working label Mar 17, 2022
@tschmidtb51
Copy link
Collaborator Author

Dear @cgi1,
I'm sorry for the confusion this caused. I know that this one is not in the scope of the original project. Therefore, I didn't label it with acceptance.
However, I found it during my tests, so I wanted to document it to make sure, I don't forget about it before claiming officially conformance against clause 5.

@cgi1
Copy link
Contributor

cgi1 commented Mar 19, 2022

Thank you @tschmidtb51 for clearing up the confusion here!
It absolutly makes sense to add issues for later adoption of the code.

@tschmidtb51
Copy link
Collaborator Author

The basic idea could be to use XPath and get all xml:lang elements as array and then process them.

@tschmidtb51
Copy link
Collaborator Author

tschmidtb51 commented Feb 2, 2023

And the XPath to get all xml:lang elements is //@xml:lang. That should result in an array.

@sthagen
Copy link
Collaborator

sthagen commented May 19, 2023

I will start implementation today 🤞🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants