Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Image triggers page re-load and loss of data in Chrome #16

Closed
rdtrimble opened this issue Apr 14, 2021 · 1 comment
Closed

Comments

@rdtrimble
Copy link
Contributor

In Chrome Version 89.0.4389.128

Clicking "Save image ⇓" downloads the image but it also triggers a reload of the page. This is a problem as the page re-load does not persist the user entered data leading to total loss of work entered so far.

Immediate fix:
change the text to WARN USER they must save the json file first!

Perhaps an actual fix, seems to work when I edit the code in my browser:

Add the attribute
target="_blank"
to the <a id="pngdownload" ... target="_blank"></a> element.

Possible other fix but more of a feature request:
Persist user entered data between sessions through localstorage?

csaladenes added a commit that referenced this issue Apr 14, 2021
@csaladenes
Copy link
Owner

In Chrome Version 89.0.4389.128

Clicking "Save image ⇓" downloads the image but it also triggers a reload of the page. This is a problem as the page re-load does not persist the user entered data leading to total loss of work entered so far.

Immediate fix:
change the text to WARN USER they must save the json file first!

Perhaps an actual fix, seems to work when I edit the code in my browser:

Add the attribute
target="_blank"
to the <a id="pngdownload" ... target="_blank"></a> element.

Possible other fix but more of a feature request:
Persist user entered data between sessions through localstorage?

Cool, see #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants