Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hover styling missing #220

Merged
merged 1 commit into from Nov 28, 2022
Merged

fix: hover styling missing #220

merged 1 commit into from Nov 28, 2022

Conversation

vtv6
Copy link
Contributor

@vtv6 vtv6 commented Nov 24, 2022

fix: #219

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 92e5be0:

Sandbox Source
chakra-react-select demo Configuration
chakra-react-select TS demo Configuration
chakra-react-select + next.js Configuration
chakra-react-select + next.js + typescript Configuration
chakra-react-select missing hover style Issue #219

@csandman
Copy link
Owner

Thanks for this! In retrospect, I'm not sure what the bg: "transparent" style was doing on the menu item. It was probably a holdover from when things were styled a bit differently, or may be something only necessary for older versions of Chakra UI. Either way, removing it appears to do the trick, on @chakra-ui/react>=2.4.0 as well as 2.3.6 so I'll say this is good to go.

@csandman csandman self-requested a review November 28, 2022 18:48
@csandman csandman merged commit 6e32104 into csandman:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Hover Styling Missing with Chakra >= 2.4.0
2 participants