Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value Style Fixes #248

Merged
merged 7 commits into from
Mar 1, 2023
Merged

Value Style Fixes #248

merged 7 commits into from
Mar 1, 2023

Conversation

csandman
Copy link
Owner

@csandman csandman commented Mar 1, 2023

  • Fix various styles, so they line up better with how the original react-select is laid out
  • Fix the condition for setting the aria-invalid prop

And meaningless stuff...

  • Move the root Select components into their own folder to keep them better organized
  • Add new README badge for weekly NPM downloads

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 1, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ec0de84:

Sandbox Source
chakra-react-select demo Configuration
chakra-react-select TS demo Configuration
chakra-react-select + next.js Configuration
chakra-react-select + next.js + typescript Configuration

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

📊 Package size report   1%↑

File Before After
dist/cjs/async-creatable-select.js 2.3 kB
dist/cjs/async-creatable-select.js.map 3.8 kB
dist/cjs/async-select.js 2.2 kB
dist/cjs/async-select.js.map 3.6 kB
dist/cjs/chakra-components/containers.js 3.9 kB 3%↑4.1 kB
dist/cjs/chakra-components/containers.js.map 8.0 kB 3%↑8.2 kB
dist/cjs/chakra-components/control.js 9.4 kB 6%↑10.0 kB
dist/cjs/chakra-components/control.js.map 17.9 kB 4%↑18.7 kB
dist/cjs/chakra-components/input.js 3.3 kB 5%↑3.5 kB
dist/cjs/chakra-components/input.js.map 6.3 kB 4%↑6.5 kB
dist/cjs/chakra-components/multi-value.js 6.2 kB 3%↑6.4 kB
dist/cjs/chakra-components/multi-value.js.map 12.7 kB 3%↑13.1 kB
dist/cjs/chakra-components/placeholder.js 1.7 kB -3.92%↓1.7 kB
dist/cjs/chakra-components/placeholder.js.map 3.4 kB -4.95%↓3.2 kB
dist/cjs/chakra-components/single-value.js 1.6 kB -5.52%↓1.5 kB
dist/cjs/chakra-components/single-value.js.map 3.2 kB -5.67%↓3.0 kB
dist/cjs/creatable-select.js 2.3 kB
dist/cjs/creatable-select.js.map 3.7 kB
dist/cjs/index.js 1.9 kB 1%↑2.0 kB
dist/cjs/index.js.map 2.9 kB 2%↑2.9 kB
dist/cjs/select.js 2.2 kB
dist/cjs/select.js.map 3.5 kB
dist/cjs/select/async-creatable-select.js 2.3 kB
dist/cjs/select/async-creatable-select.js.map 3.8 kB
dist/cjs/select/async-select.js 2.2 kB
dist/cjs/select/async-select.js.map 3.6 kB
dist/cjs/select/creatable-select.js 2.3 kB
dist/cjs/select/creatable-select.js.map 3.7 kB
dist/cjs/select/select.js 2.2 kB
dist/cjs/select/select.js.map 3.5 kB
dist/cjs/use-chakra-select-props.js 5.2 kB -0.41%↓5.1 kB
dist/cjs/use-chakra-select-props.js.map 7.9 kB -0.66%↓7.9 kB
dist/esm/async-creatable-select.js 855 B
dist/esm/async-creatable-select.js.map 1.9 kB
dist/esm/async-select.js 799 B
dist/esm/async-select.js.map 1.8 kB
dist/esm/chakra-components/containers.js 3.5 kB 4%↑3.6 kB
dist/esm/chakra-components/containers.js.map 7.2 kB 3%↑7.4 kB
dist/esm/chakra-components/control.js 8.6 kB 7%↑9.2 kB
dist/esm/chakra-components/control.js.map 16.9 kB 2%↑17.3 kB
dist/esm/chakra-components/input.js 3.0 kB 6%↑3.2 kB
dist/esm/chakra-components/input.js.map 5.2 kB 4%↑5.4 kB
dist/esm/chakra-components/multi-value.js 5.6 kB 4%↑5.9 kB
dist/esm/chakra-components/multi-value.js.map 11.9 kB 3%↑12.3 kB
dist/esm/chakra-components/placeholder.js 1.5 kB -4.59%↓1.4 kB
dist/esm/chakra-components/placeholder.js.map 2.7 kB -6.28%↓2.5 kB
dist/esm/chakra-components/single-value.js 1.3 kB -6.56%↓1.2 kB
dist/esm/chakra-components/single-value.js.map 2.5 kB -7.26%↓2.3 kB
dist/esm/creatable-select.js 823 B
dist/esm/creatable-select.js.map 1.8 kB
dist/esm/index.js 659 B 4%↑687 B
dist/esm/index.js.map 1.9 kB 3%↑1.9 kB
dist/esm/select.js 767 B
dist/esm/select.js.map 1.7 kB
dist/esm/select/async-creatable-select.js 856 B
dist/esm/select/async-creatable-select.js.map 1.9 kB
dist/esm/select/async-select.js 800 B
dist/esm/select/async-select.js.map 1.8 kB
dist/esm/select/creatable-select.js 824 B
dist/esm/select/creatable-select.js.map 1.9 kB
dist/esm/select/select.js 768 B
dist/esm/select/select.js.map 1.7 kB
dist/esm/use-chakra-select-props.js 4.9 kB -0.43%↓4.9 kB
dist/esm/use-chakra-select-props.js.map 6.8 kB -0.76%↓6.8 kB
dist/types/async-creatable-select.d.ts 624 B
dist/types/async-creatable-select.d.ts.map 636 B
dist/types/async-select.d.ts 550 B
dist/types/async-select.d.ts.map 608 B
dist/types/creatable-select.d.ts 582 B
dist/types/creatable-select.d.ts.map 616 B
dist/types/index.d.ts 1.2 kB 5%↑1.2 kB
dist/types/index.d.ts.map 981 B 0.4%↑985 B
dist/types/select.d.ts 472 B
dist/types/select.d.ts.map 556 B
dist/types/select/async-creatable-select.d.ts 624 B
dist/types/select/async-creatable-select.d.ts.map 646 B
dist/types/select/async-select.d.ts 550 B
dist/types/select/async-select.d.ts.map 618 B
dist/types/select/creatable-select.d.ts 582 B
dist/types/select/creatable-select.d.ts.map 626 B
dist/types/select/select.d.ts 472 B
dist/types/select/select.d.ts.map 566 B
README.md 46.2 kB 0.5%↑46.4 kB
Total (Includes all files) 426.6 kB 1%↑431.1 kB
Tarball size 71.8 kB 1%↑72.6 kB
Unchanged files
File Size
dist/cjs/chakra-components/index.js 2.8 kB
dist/cjs/chakra-components/index.js.map 3.8 kB
dist/cjs/chakra-components/menu.js 11.7 kB
dist/cjs/chakra-components/menu.js.map 22.8 kB
dist/cjs/module-augmentation.js 61 B
dist/cjs/module-augmentation.js.map 9.7 kB
dist/cjs/types.js 47 B
dist/cjs/types.js.map 3.6 kB
dist/cjs/utils.js 3.1 kB
dist/cjs/utils.js.map 5.6 kB
dist/esm/chakra-components/index.js 1.3 kB
dist/esm/chakra-components/index.js.map 2.5 kB
dist/esm/chakra-components/menu.js 10.8 kB
dist/esm/chakra-components/menu.js.map 21.7 kB
dist/esm/module-augmentation.js 58 B
dist/esm/module-augmentation.js.map 9.7 kB
dist/esm/types.js 44 B
dist/esm/types.js.map 3.6 kB
dist/esm/utils.js 2.9 kB
dist/esm/utils.js.map 4.7 kB
dist/types/chakra-components/containers.d.ts 704 B
dist/types/chakra-components/containers.d.ts.map 322 B
dist/types/chakra-components/control.d.ts 1.7 kB
dist/types/chakra-components/control.d.ts.map 589 B
dist/types/chakra-components/index.d.ts 5.1 kB
dist/types/chakra-components/index.d.ts.map 208 B
dist/types/chakra-components/input.d.ts 295 B
dist/types/chakra-components/input.d.ts.map 237 B
dist/types/chakra-components/menu.d.ts 1.3 kB
dist/types/chakra-components/menu.d.ts.map 490 B
dist/types/chakra-components/multi-value.d.ts 1.1 kB
dist/types/chakra-components/multi-value.d.ts.map 433 B
dist/types/chakra-components/placeholder.d.ts 325 B
dist/types/chakra-components/placeholder.d.ts.map 252 B
dist/types/chakra-components/single-value.d.ts 326 B
dist/types/chakra-components/single-value.d.ts.map 254 B
dist/types/module-augmentation.d.ts 9.9 kB
dist/types/module-augmentation.d.ts.map 2.0 kB
dist/types/types.d.ts 3.4 kB
dist/types/types.d.ts.map 3.5 kB
dist/types/use-chakra-select-props.d.ts 613 B
dist/types/use-chakra-select-props.d.ts.map 255 B
dist/types/utils.d.ts 746 B
dist/types/utils.d.ts.map 328 B
LICENSE.md 1.1 kB
package.json 4.0 kB

🤖 This report was automatically generated by pkg-size-action

@csandman csandman merged commit df2e615 into main Mar 1, 2023
@csandman csandman deleted the value-style-fixes branch March 1, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant