Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import chakraui/icon #277

Merged
merged 3 commits into from
Sep 11, 2023
Merged

fix: import chakraui/icon #277

merged 3 commits into from
Sep 11, 2023

Conversation

jonashger
Copy link
Contributor

@jonashger jonashger commented Sep 9, 2023

Closes #276

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 9, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2d8efd3:

Sandbox Source
chakra-react-select demo Configuration
chakra-react-select TS demo Configuration
chakra-react-select + next.js Configuration
chakra-react-select + next.js + typescript Configuration

Copy link

@Naman-Garaaz Naman-Garaaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an urgent bug fixes

@bujarinnovationnorway
Copy link

Could we merge this quickly? I am in the process of releasing my app and this came at the worst time possible.

Copy link

@MasterJuan MasterJuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it's wrong to include more than once the same package.
"'@chakra-ui/icon' import is duplicated".
It shouldn't be like this?
import { Icon, IconProps } from '@chakra-ui/icon';

Copy link
Owner

@csandman csandman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a small tweak to remove this dependency in general, but overall LGTM! Thanks for fixing!

@csandman csandman merged commit 2b01727 into csandman:main Sep 11, 2023
4 of 5 checks passed
@csandman
Copy link
Owner

csandman commented Sep 11, 2023

I think that it's wrong to include more than once the same package.
"'@chakra-ui/icon' import is duplicated".
It shouldn't be like this?
import { Icon, IconProps } from '@chakra-ui/icon';

There's nothing wrong with this when one of the top level imports is import type { by the way. It wasn't even possible to do an inline import { type... until more recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Breaking Change in chakraui/icon
5 participants