Fix for V3: Prevent a selected option from being removed when isDisabled is passed #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csandman
reviewed
Nov 13, 2023
| // When disabled, react-select sets the pointer-state to none which prevents | ||
| // the `not-allowed` cursor style from chakra from getting applied to the | ||
| // Control when it is disabled | ||
| pointerEvents: "auto", | ||
| }; |
There was a problem hiding this comment.
I'm cool with this change, but can you add the rest of my change from the original PR so the hover styling matches the rest of the disabled chakra components?
Suggested change
| }; | |
| ...(isDisabled ? { cursor: "not-allowed" } : {}), | |
| }; |
There was a problem hiding this comment.
Yes of course, sorry I missed it earlier! Added now 👍
csandman
requested changes
Nov 13, 2023
|
@csandman Thanks for the feedback, I've changed it now. |
|
Great, looks good! Merged and released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: on
chakra-react-selectv3 users can remove selected options whenisDisabledis passed usingReported here for v4: #168
Fixed here for > v4: #169
This PR aims to fix this issue for v3