Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Csandman/tag remove fix #33

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Csandman/tag remove fix #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9a4e57
Fix the `MultiValueRemove` component
csandman Jan 12, 2022
4b84032
3.0.1
csandman Jan 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "chakra-react-select",
"version": "3.0.0",
"version": "3.0.1",
"description": "A chakra-ui wrapper for the popular select library react-select",
"license": "MIT",
"author": "Chris Sandvik <chris.sandvik@gmail.com>",
Expand Down
6 changes: 5 additions & 1 deletion src/chakra-components.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,8 +471,12 @@ const MultiValueRemove = <
}

return (
// @ts-ignore the `innerProps` type is not compatible with the props
// accepted by the `TagCloseButton`. The most likely solution in the long
// term is using a `chakra.button` instead of a TagCloseButton and styling
// it using the multi style config of a tag close button.
<TagCloseButton
className={innerProps.className}
{...innerProps}
sx={sx}
tabIndex={-1}
data-focus={isFocused ? true : undefined}
Expand Down