debounce server restart at 100ms when watching server files #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.serverRestartDelayTime = 100; | ||
|
|
||
| var serverRestartDelayTime = 100; | ||
| this.scheduleServerRestart = _.debounce(this.restartHttpServer, this.serverRestartDelayTime); |
There was a problem hiding this comment.
this.serverRestartDelayTime should be serverRestartDelayTime
|
@EndangeredMassa Thanks for working on this. Unfortunately the debounce test is failing now. I don't have time right now to look into it though. When you get your environment up and running again, don't forget to run the smoke test manually, which isn't part of |
|
Sure thing. I'll spend more time on this tomorrow. |
|
I rebased my branch on master, but now this PR looks like a mess. If you @csantero rebase this on master, will that sync it back up? |
csantero
force-pushed
the
restart-server
branch
from
22ee045
to
32e46a4
Compare
|
@EndangeredMassa I reset my branch to yours and force pushed. Looks good, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates based on comments on PR#2265 to ember-cli itself.