Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulator Voc doesn't saturate #113

Closed
csatt opened this issue Jul 25, 2020 · 0 comments
Closed

Simulator Voc doesn't saturate #113

csatt opened this issue Jul 25, 2020 · 0 comments
Assignees
@csatt
Labels
bug

Comments

@csatt
Copy link
Owner

csatt commented Jul 25, 2020

The Voc value is translated to an ADC value, but that value is not capped at 4096. The resulting simulated IV curve shows the Voc point at the specified voltage even if that voltage would saturate the ADC.
@csatt csatt added the bug label Jul 25, 2020
@csatt csatt self-assigned this Jul 25, 2020
csatt added a commit that referenced this issue Jul 25, 2020
@csatt
Simulator: Saturate Voc at ADC_MAX (Issue #113)
8f1ece9 
Saturate voc_adc at ADC_MAX.
@csatt csatt closed this as completed Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csatt csatt

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@csatt