Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulation creates separate log file #126

Closed
csatt opened this issue Oct 31, 2020 · 0 comments
Closed

Simulation creates separate log file #126

csatt opened this issue Oct 31, 2020 · 0 comments
Assignees
Labels

Comments

@csatt
Copy link
Owner

csatt commented Oct 31, 2020

When the simulator is run from the Help menu, it creates a new log file with the simulation logging. This is wrong. The simulation logging should be included in the existing log file. When the simulator is run standalone, it should still create a new log file, however.

@csatt csatt added the bug label Oct 31, 2020
@csatt csatt self-assigned this Oct 31, 2020
csatt added a commit that referenced this issue Oct 31, 2020
To fix this, the following changes were made:
  - Add optional logger parameter to the IV_Swinger2 class initializer
  - Add logger parameter to IV_Swinger2 configure logging method
  - Modify configure_logging to just set the logger attribute to the passed value if it is set
  - Add optional logger parameter to the IV_Swinger2_sim class initializer and pass that to the IV_Swinger2 initializer
  - Add optional logger parameter to the SimulatorDialog class initializer and pass that to the IV_Swinger2_sim instantiation
  - Pass the existing logger to the SimulatorDialog instantiaton in the run_simulator method in the MenuBar class of the main GUI

This commit also includes one unrelated whitespace fix in IV_Swinger2_gui.py

All changes are made to both python and python3 files.
@csatt csatt closed this as completed Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant