Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlay user action logging misleading/incorrect #138

Closed
csatt opened this issue Nov 11, 2020 · 0 comments
Closed

Overlay user action logging misleading/incorrect #138

csatt opened this issue Nov 11, 2020 · 0 comments
Assignees
@csatt
Labels
bug

Comments

@csatt
Copy link
Owner

csatt commented Nov 11, 2020

Issue #115 added logging of user actions. There are two problems with the logging of overlay-related user actions:

  • The message "(Wizard) clicked Overlay button" is logged when the user reselects runs to be included in the overlay
  • The message "(Wizard) dragged and dropped overlay curve" is logged when the user clicks on anything in the overlay widget, not necessarily dragging and dropping
@csatt csatt added the bug label Nov 11, 2020
@csatt csatt self-assigned this Nov 11, 2020
csatt added a commit that referenced this issue Nov 11, 2020
@csatt
Fix overlay user even logging (Issue #138)
f706d06 
1) Set event="reselect" for call to overlay_runs( ) method in select() method. Suppress logging "(Wizard) clicked Overlay button" if event is "reselect"

2) Only log "(Wizard) clicked Overlay button" if the overlays are reordered
@csatt csatt closed this as completed Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csatt csatt

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@csatt