Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Make Desktop Shortcut" fails on Windows #149

Closed
csatt opened this issue Nov 18, 2020 · 0 comments
Closed

"Make Desktop Shortcut" fails on Windows #149

csatt opened this issue Nov 18, 2020 · 0 comments
Assignees
Labels

Comments

@csatt
Copy link
Owner

csatt commented Nov 18, 2020

The README files in the python and python3 directories are missing one package that needs to be installed on Windows: "pywin32"

If it is not installed, the "Make Desktop Shortcut" button generates an error dialog saying "ERROR: could not create shortcut"

In addition to the README files needing to be corrected, this error message provides no clue as to what the problem is. The failure to install pywin32 should cause "import win32com.client" to fail with an ImportError exception. But currently, it is protected with try/except so it doesn't fail on non-Windows machines. Instead, the import should only be attempted if sys.platform is "win32" and the try/except should be removed.

@csatt csatt added the bug label Nov 18, 2020
@csatt csatt self-assigned this Nov 18, 2020
csatt added a commit that referenced this issue Nov 18, 2020
 - Added pywin32 to pip install list for Windows
 - Removed try/except around import of win32com.client and added 'if sys.platform == "win32"'
@csatt csatt closed this as completed Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant