Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory not removed on failed run #165

Closed
csatt opened this issue Dec 20, 2020 · 0 comments
Closed

Directory not removed on failed run #165

csatt opened this issue Dec 20, 2020 · 0 comments
Assignees
Labels

Comments

@csatt
Copy link
Owner

csatt commented Dec 20, 2020

This is a longstanding problem, presumably since the run_info file was added.

When there is a failure like Isc polling timeout, the whole directory is supposed to be removed by the clean_up_after_failure() method in IV_Swinger2.py. But that method inferred that if the run directory had two files, they were the ADC CSV file and the data points CSV file and it would not remove the directory. But when there is a run_info file (for sensor info), the directory is not removed because it contains the ADC CSV file and the run_info file.

This was a terrible way to determine that the directory contained these two files. It should be explicit.

@csatt csatt added the bug label Dec 20, 2020
@csatt csatt self-assigned this Dec 20, 2020
csatt added a commit that referenced this issue Dec 20, 2020
Instead of inferring that run_dir contains the ADC and data points CSV files if it contains two files, explcitly check that it indeed contains those two files.
@csatt csatt closed this as completed Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant