Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing port or polling interval doesn't take effect if rcmd is already enabled #198

Closed
csatt opened this issue Apr 5, 2023 · 0 comments
Assignees
Labels

Comments

@csatt
Copy link
Owner

csatt commented Apr 5, 2023

If remote command monitoring is already enabled, and the user changes either the port number or the polling interval, the change does not take effect unless the user first disables remote commands (and clicks OK), or kills the app (or instance.) The change should take effect immediately when the user clicks OK. This implies that the currently running remote command monitor needs to be stopped before restarting it with the new value(s).

@csatt csatt self-assigned this Apr 5, 2023
@csatt csatt added the bug label Apr 5, 2023
csatt added a commit that referenced this issue Apr 5, 2023
Modified the rcmd_apply() method to handle the case where remote commands are already enabled, and the user changes the port number and/or the polling interval. Previously, such a change would not take effect when the user clicked OK. They would only take effect if the GUI was closed or if the user disabled and then re-enabled remote commands.

Now, in this case, the remote command monitor is canceled and restarted with the new port and/or interval.
@csatt csatt closed this as completed Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant