Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wizard copy needs to include instance path #203

Closed
csatt opened this issue Apr 9, 2023 · 0 comments
Closed

Wizard copy needs to include instance path #203

csatt opened this issue Apr 9, 2023 · 0 comments
Assignees
@csatt
Labels
bug

Comments

@csatt
Copy link
Owner

csatt commented Apr 9, 2023

Currently, the Copy button in the Results Wizard does not distinguish between normal (main GUI) runs and instance runs (see Issue #192). It just copies the leaf folder (yymmdd_hh_mm_ss) to the chosen destination. This makes it difficult to determine which instance the run was for. And since it is possible for runs in different instances to have been performed at the same time, it could even result in folder name conflicts.

The destination path should include the same inst/ levels in its hierarchy that the source path does.
csatt added a commit that referenced this issue Apr 9, 2023
@csatt
Include inst path in copy destination (Issue #203)
562ecb8 
Modify the get_dest_dir() method to insert the "inst/<name>" part of the source path in the destination path, if it exists.

Take advantage of the fact that os.path.join inserts directory separators only for non-empty segments. By initializing inst_path and overlays to "", this avoids multiple branches and should have been done previously.
@csatt csatt closed this as completed Apr 9, 2023
@csatt csatt self-assigned this Apr 9, 2023
@csatt csatt added the bug label Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csatt csatt

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@csatt