Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve EMR advanced current calibration #206

Closed
csatt opened this issue Apr 13, 2023 · 0 comments
Closed

Improve EMR advanced current calibration #206

csatt opened this issue Apr 13, 2023 · 0 comments
Assignees

Comments

@csatt
Copy link
Owner

csatt commented Apr 13, 2023

One of the main advantages of the SSR and FET designs over the EMR design has been the ability to accurately calibrate the current measurements. Current measurement calibration for the EMR design is very cumbersome (requiring an external switch and a clear sunny day.)

However, hiding in plain sight has been a much better way. In fact, this method works with the current software if the user "lies" about which type of relay they have on the advanced current calibration dialog. It requires a jumper wire with an alligator clip on one end. This jumper is connected between the red binding post (PV+) and the exposed leg of the bleed resistor (Rb). The exposed leg of Rb is the LOAD_CAP- signal, which is also connected to the top of the shunt resistor. That creates a path between PV+ and PV- that bypasses the load capacitors but goes through the shunt. It is safe for this path to carry 10A of current (or more) indefinitely. As with the SSR and FET designs, this makes it possible to accurately calibrate an EMR-based IVS2 with a bench power supply (no sun required.)

The software should be changed so the user doesn't need to "lie" about which type of relay they have. When the relay type is EMR on the advanced current calibration dialog, the actions should be the same as they are when the SSR/FET relay type is selected, except the "cooling off" period should not be enforced. The help dialog should be changed to describe the new methodology.

@csatt csatt self-assigned this Apr 13, 2023
csatt added a commit that referenced this issue Apr 13, 2023
See Issue #206

Renamed the request_ssr_adv_current_calibration_val method to req_adv_current_calibration_val, but the only change is to suppress checking the cooling off period if the relay type is not SSR/FET (had to add a parameter).

When the user selects EMR on the advanced current calibration dialog, the req_adv_current_calibration_val method is now called regardless of relay type. The help dialog is consolidated to a single AdvCurrentCalHelpDialog class. It has an added step 0, which is for the EMR jumper wire, but the other steps are unchanged.
@csatt csatt closed this as completed Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant