Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow the "active relay" option when Arduino is not connected #46

Closed
csatt opened this issue Jan 25, 2019 · 0 comments
Closed

Disallow the "active relay" option when Arduino is not connected #46

csatt opened this issue Jan 25, 2019 · 0 comments
Assignees
@csatt
Labels
bug

Comments

@csatt
Copy link
Owner

csatt commented Jan 25, 2019

The "relay is active-high" checkbox on the Arduino tab of Preferences should not be possible to check when the Arduino isn't connected. Currently it does complain, but it gives the misleading message that the Arduino code doesn't support that option. It also leaves the box checked even though the action was not taken.
csatt added a commit that referenced this issue Jan 25, 2019
@csatt
Disallow active-high relay if Arduino is not connected (Issue #46)
ba5ceea 
Now check the "arduino_ready" flag before setting the active-high checkbox.  Also leave box unchecked for all failure cases.  Also add warning in Help and confirmation dialog that this option could cause damage if selected on an SSR IVS2.
@csatt csatt closed this as completed Jan 25, 2019
@csatt csatt self-assigned this Feb 6, 2019
@csatt csatt added the bug label Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csatt csatt

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@csatt