remove api endpoints to get all reviews and all review descriptions

cschalenborgh · Apr 12, 2017 · baef3e7 · baef3e7
1 parent c09092a
commit baef3e7
Show file tree

Hide file tree

Showing 11 changed files with 33 additions and 339 deletions.
diff --git a/lib/ZalandoPHP/Operations/ArticlesReviews.php b/lib/ZalandoPHP/Operations/ArticlesReviews.php
@@ -26,10 +26,14 @@
 class ArticlesReviews extends AbstractOperation
 {
 
-    protected $endpoint         = 'article-reviews?articleId={articleId}';
+    protected $endpoint         = 'articles/{articleId}/reviews';
 
     public function __construct($articleId = '')
     {
+        if (strlen($articleId) == 0) {
+            throw new \InvalidArgumentException('articleId is empty.');
+        }
+
         $this->endpoint = str_replace('{articleId}', $articleId, $this->endpoint);
     }
 

diff --git a/lib/ZalandoPHP/Operations/ArticlesReviewsSummaries.php b/lib/ZalandoPHP/Operations/ArticlesReviewsSummaries.php
diff --git a/lib/ZalandoPHP/Operations/Reviews.php b/lib/ZalandoPHP/Operations/Reviews.php
@@ -30,6 +30,10 @@ class Reviews extends AbstractOperation
 
     public function __construct($reviewId = '')
     {
+        if (strlen($reviewId) == 0) {
+            throw new \InvalidArgumentException('reviewId is empty.');
+        }
+
         $this->endpoint = str_replace('{reviewId}', $reviewId, $this->endpoint);
     }
 

diff --git a/lib/ZalandoPHP/Operations/ReviewsSummaries.php b/lib/ZalandoPHP/Operations/ReviewsSummaries.php
diff --git a/samples/Articles/getArticlesReviewsSummaries.php b/samples/Articles/getArticlesReviewsSummaries.php
diff --git a/samples/Reviews/getReviews.php b/samples/Reviews/getReviews.php
@@ -40,10 +40,7 @@
 
 
 // return one
-//$reviews = new Reviews('4385857-AN651H06H-Q11');
-
-// return all
-$reviews = new Reviews();
+$reviews = new Reviews('4385857-AN651H06H-Q11');
 $formattedResponse = $zalandoPHP->runOperation($reviews);
 
 echo '<pre>';

diff --git a/samples/Reviews/getReviewsSummaries.php b/samples/Reviews/getReviewsSummaries.php
diff --git a/tests/ZalandoPHP/Test/Operations/Types/ArticlesReviewsSummariesTest.php b/tests/ZalandoPHP/Test/Operations/Types/ArticlesReviewsSummariesTest.php
diff --git a/tests/ZalandoPHP/Test/Operations/Types/ArticlesReviewsTest.php b/tests/ZalandoPHP/Test/Operations/Types/ArticlesReviewsTest.php
@@ -24,10 +24,20 @@ class ArticlesReviewsTest extends \PHPUnit_Framework_TestCase
 
     public function testValidPage()
     {
-        $reviews = new ArticlesReviews();
+        $reviews = new ArticlesReviews(123);
         $reviews->setPage(1);
 
         $this->assertEquals(1, $reviews->getPage());
     }
 
+    /**
+     * @expectedException Exception
+     */
+    public function testInvalidArticleId()
+    {
+        $operation = new ArticlesReviews();
+        $zalando = new ZalandoPHP();
+
+        $zalando->runOperation($operation);
+    }
 }