Skip to content

Commit

Permalink
Allow additional request params
Browse files Browse the repository at this point in the history
  • Loading branch information
morten committed Feb 15, 2011
1 parent f0a15de commit 0efa37d
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
9 changes: 7 additions & 2 deletions lib/onelogin/saml/authrequest.rb
Expand Up @@ -5,7 +5,7 @@

module Onelogin::Saml
class Authrequest
def create(settings)
def create(settings, params = {})
uuid = UUID.new.generate
time = Time.now.strftime("%Y-%m-%dT%H:%M:%SZ")

Expand All @@ -20,8 +20,13 @@ def create(settings)
deflated_request = Zlib::Deflate.deflate(request, 9)[2..-5]
base64_request = Base64.encode64(deflated_request)
encoded_request = CGI.escape(base64_request)
request_params = "?SAMLRequest=" + encoded_request

settings.idp_sso_target_url + "?SAMLRequest=" + encoded_request
params.each_pair do |key, value|
request_params << "&#{key}=#{CGI.escape(value)}"
end

settings.idp_sso_target_url + request_params
end

end
Expand Down
7 changes: 7 additions & 0 deletions test/ruby-saml_test.rb
Expand Up @@ -77,6 +77,13 @@ class RubySamlTest < Test::Unit::TestCase
assert auth_url =~ /^http:\/\/stuff\.com\?SAMLRequest=/
payload = CGI.unescape(auth_url.split("=").last)
end

should "accept extra parameters" do
settings = Onelogin::Saml::Settings.new
settings.idp_sso_target_url = "http://stuff.com"
auth_url = Onelogin::Saml::Authrequest.new.create(settings, { :hello => "there" })
assert auth_url =~ /&hello=there$/
end
end

end

0 comments on commit 0efa37d

Please sign in to comment.