-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace nose with pytest #37
Conversation
aae596d
to
634ea5e
Compare
Now I made it to run at least on ubuntu and macos. How do I set the PYTHONPATH on Windows, please? |
Hello, Thank you so much for this change! Instead of For my personal dev, I use pipenv: https://pipenv.pypa.io/en/latest/. I would ordinarily uninstall nose with |
.github/workflows/build.yml
Outdated
@@ -43,4 +43,4 @@ jobs: | |||
|
|||
- name: Test | |||
run: | | |||
nosetests --with-doctest --doctest-extension=rst | |||
PYTHONPATH=. py.test --doctest-modules --doctest-glob='*.rst' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be able to run without PYTHONPATH=
pytest --doctest-modules --doctest-glob='*.rst'
This works locally for me on Windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am quite certain I tried it (only with py.test, not pytest) and that it failed on Ubuntu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Yes, you're right. It is still failing.
The only difference I see at this point between this branch and the documentation is that the documentation installs pytest in the same stage that it executes under. That could be the last possible difference, but I'm not sure why it would matter at all (I'd guess nose and pytest install differently).
I am happy to merge this change and then work on getting the build action working again separately. The changes themselves to the tests are good :)
* replace nose with pytest * try to build it without PYTHONPATH
On Python 3.9 or 3.10 nose will stop working, so let us transform the tests to pytest.
Sorry, I do not know how to purge nose from Pipfile.lock, could you please do it yourself?