RabbitMQ Heartbeat and Queue Argument Support #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to Maven + Metrics + SimpleSpec. Thanks, Jarred!
…licy: all) * Added support for specifying a heartbeat on a connection
…licy: all) * Added support for specifying a heartbeat on a connection
- com.rabbitmq.amqp-client from 2.7.1 to 2.8.4 - redis.clients.jedis from 2.0.0. to 2.1.0 - com.googlecode.json-simple.json-simple from 1.1 to 1.1.1 - javax.mail.mail from 1.4.5-rc1 to 1.4.5 - com.yammer.metrics.metrics-core from 2.0.3 to 2.1.2 - com.yammer.metrics.metrics-servlet from 2.0.3 to 2.1.2
- com.rabbitmq.amqp-client from 2.7.1 to 2.8.4 - redis.clients.jedis from 2.0.0. to 2.1.0 - com.googlecode.json-simple.json-simple from 1.1 to 1.1.1 - javax.mail.mail from 1.4.5-rc1 to 1.4.5 - com.yammer.metrics.metrics-core from 2.0.3 to 2.1.2 - com.yammer.metrics.metrics-servlet from 2.0.3 to 2.1.2
|
Hey Justin, this looks rad - thanks a ton for putting it together! I'll read the diff in full this afternoon. Hope your week's wrapping up well.
|
|
hey @cscotta, not to rush you or anything, but do you think this might get merged in? Thanks a lot for your work on this framework. It's helped us out tremendously. |
|
hey @cscotta, is it possible to get this merged in? Thanks a lot. |
|
ping |
|
pong 2012/10/18 Justin Plock notifications@github.com
|
|
Opened a cleaner pull request at #12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow specifying a heartbeat on the RabbitMQ connection (we connect to RabbitMQ through a load balancer that kills inactive connections). Also allow specifying optional arguments for the RabbitMQ queues (such as x-ha-policy: all).
Also cleaned up some whitespace issues. Sorry for all the pull requests. I had to update the author in some of my commits so they may look a bit messy.
I also just fixed the metrics page to use the default MetricsRegistry so the metrics are properly displayed on the port 1228 status page.