RabbitMQ Heartbeat and Queue Argument Support #9

Closed
wants to merge 9 commits into
from

Conversation

Projects
None yet
2 participants

jplock commented Jul 5, 2012

Allow specifying a heartbeat on the RabbitMQ connection (we connect to RabbitMQ through a load balancer that kills inactive connections). Also allow specifying optional arguments for the RabbitMQ queues (such as x-ha-policy: all).

Also cleaned up some whitespace issues. Sorry for all the pull requests. I had to update the author in some of my commits so they may look a bit messy.

I also just fixed the metrics page to use the default MetricsRegistry so the metrics are properly displayed on the port 1228 status page.

cscotta and others added some commits Apr 21, 2012

Merge pull request #5 from jarreds/maven_metrics
Switch to Maven + Metrics + SimpleSpec. Thanks, Jarred!
* Added support for specifying RabbitMQ queue arguments (like x-ha-po…
…licy: all)

* Added support for specifying a heartbeat on a connection
* Added support for specifying RabbitMQ queue arguments (like x-ha-po…
…licy: all)

* Added support for specifying a heartbeat on a connection
Upgraded dependencies:
- com.rabbitmq.amqp-client from 2.7.1 to 2.8.4
- redis.clients.jedis from 2.0.0. to 2.1.0
- com.googlecode.json-simple.json-simple from 1.1 to 1.1.1
- javax.mail.mail from 1.4.5-rc1 to 1.4.5
- com.yammer.metrics.metrics-core from 2.0.3 to 2.1.2
- com.yammer.metrics.metrics-servlet from 2.0.3 to 2.1.2
Upgraded dependencies:
- com.rabbitmq.amqp-client from 2.7.1 to 2.8.4
- redis.clients.jedis from 2.0.0. to 2.1.0
- com.googlecode.json-simple.json-simple from 1.1 to 1.1.1
- javax.mail.mail from 1.4.5-rc1 to 1.4.5
- com.yammer.metrics.metrics-core from 2.0.3 to 2.1.2
- com.yammer.metrics.metrics-servlet from 2.0.3 to 2.1.2
Owner

cscotta commented Jul 6, 2012

Hey Justin, this looks rad - thanks a ton for putting it together! I'll read the diff in full this afternoon. Hope your week's wrapping up well.

  • Scott

jplock commented Jul 10, 2012

hey @cscotta, not to rush you or anything, but do you think this might get merged in? Thanks a lot for your work on this framework. It's helped us out tremendously.

jplock commented Aug 20, 2012

hey @cscotta, is it possible to get this merged in? Thanks a lot.

jplock commented Oct 18, 2012

ping

@ghost

ghost commented Oct 18, 2012

pong

2012/10/18 Justin Plock notifications@github.com

ping


Reply to this email directly or view it on GitHubhttps://github.com/cscotta/Octobot/pull/9#issuecomment-9563113.

@jplock jplock closed this Nov 6, 2012

jplock commented Nov 6, 2012

Opened a cleaner pull request at #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment