Skip to content

Commit

Permalink
feat: new permission required for Bluetooth
Browse files Browse the repository at this point in the history
  • Loading branch information
sowens-csd committed Oct 24, 2023
1 parent 3bd9b05 commit 3a808cb
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions speech_to_text/android/src/main/AndroidManifest.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@
package="com.csdcorp.speech_to_text">

<uses-permission android:name="android.permission.BLUETOOTH_CONNECT" />
<uses-permission android:name="android.permission.MODIFY_PHONE_STATE" />
</manifest>

3 comments on commit 3a808cb

@giovanni256
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?
The MODIFY_PHONE_STATE permission is asking for android.hardware.telephony which makes Android tablets without LTE not available anymore for the download.

Can you remove it?
@sowens-csd

@sowens-csd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a look at that. I don't think I intentionally added it. If I remember correctly it was an Android Studio automatic change. I'll look into why it recommended it and whether it's necessary. I certainly don't want to exclude non-LTE tablets, that would be a very bad change.

@sowens-csd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that looks like an error to me. I can't find any support for needing that permission for speech recognition. I'll put out a .1 release. Thanks for the help.

Please sign in to comment.