Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_case/DemoData #12

Open
cefect opened this issue Oct 20, 2023 · 0 comments
Open

test_case/DemoData #12

cefect opened this issue Oct 20, 2023 · 0 comments

Comments

@cefect
Copy link
Collaborator

cefect commented Oct 20, 2023

A few suggestions/questions on improving the test/demo data:

  • It's unclear what the difference between the 'DemoData' and the 'test_case/PeeDee' folders are (it looks like a zip of the PeeDee case is actually duplicated inside 'DemoData'). It would be nice if this could be cleaned up.
  • there is no documentation on the demo data. Where does it come from? What is each file? etc.
  • outputs from the tool would also be helpful so the user can compare their outputs
  • the PeeDee data appears to have invalid geometry (I created .\test_case\PeeDee\WaterExtent_fixed.gpkg with corrected geometry on my fork). Also, there are two tiny artifacts in the inundation polygon (see below) that cause problems for FwDET (even with the slope filtering). These should be fixed or mentioned in the readme so the user is not confused as to why their outputs are problematic.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant