Commits on Apr 19, 2024

1. Add virtual destructor …

   The Bmi base class definition needs to define its destructor as `virtual` to enable derived classes to support accurate destruction.
   
   Cf https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rh-dtor
   
   This is technically an ABI change impacting any existing code. To avoid potential failures and definite UB from ODR violation, all clients and implementations within a given system will need to be (re-) built against matching versions of this header.
   
   It's unclear whether it's a breaking change of the BMI specification itself. The depends on whether the reference to this file is normative or exemplary.

   

   PhilMiller committed Apr 19, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 0794d20
   • Browse repository at this point

   Copy the full SHA

   0794d20 View commit details

   Browse the repository at this point in the history