Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Save Our Ship 2] SOS2 Ship Generation Issues emulated in vanilla #653

Closed
IK3Holy opened this issue Sep 8, 2021 · 0 comments · Fixed by #657
Closed

[Save Our Ship 2] SOS2 Ship Generation Issues emulated in vanilla #653

IK3Holy opened this issue Sep 8, 2021 · 0 comments · Fixed by #657
Labels
Bug Something isn't working. Confirmed This issue has been confirmed by a tester and will be passed on to programmers. Reproducible This issue is reproducible. RT 2.5.15 RT Version 2.5.15 Vanilla RT This issue is reproducible when running only RimWorld, DLCs, Harmony, HugsLib & RimThreaded.
Projects
RT Known Issues & Roadmap Testing To Do List Mod Compatibility Issue Categories
Milestone
SOS2 Compatibility

Comments

@IK3Holy
Copy link

IK3Holy commented Sep 8, 2021 •
edited

Describe the bug

Issue is related to issue #639 [Save Our Ship 2] SOS2 Ship Generation Issues however discord user Simonlagun found a way to reproduce the bug in vanilla rimworld.

Steps to reproduce the behavior (VERY IMPORTANT)

  1. Open the save attached or create a new save in a temperate swamp biome
  2. Turn on dev mode
  3. In the "debug options menu" click on Make Colony (Full) under Autotests
  4. The game should freeze briefly
  5. The base should only partially spawn and an error should show in the logs.

Error Logs

Player.log

https://github.com/IK3Holy/Misc/blob/main/Player%20(2).log

HugsLib log

https://gist.github.com/be9461ce2ab822da3edd0ac268e94c6c

Save file

Before test 1.zip

Screenshots

Half generated test base:
image

Mod list (For vanilla report, it has to be same as below list.)

  • Harmony
  • Core
  • Royalty (Optional)
  • Ideology (Optional)
  • HugsLib
  • RimThreaded
@IK3Holy IK3Holy added Bug Something isn't working. Reproducible This issue is reproducible. Vanilla RT This issue is reproducible when running only RimWorld, DLCs, Harmony, HugsLib & RimThreaded. labels Sep 8, 2021
@IK3Holy IK3Holy mentioned this issue Sep 8, 2021
Closed
@IK3Holy IK3Holy changed the title SOS2 Ship Generation Issues emulated in vanilla [Save Our Ship 2] SOS2 Ship Generation Issues emulated in vanilla Sep 8, 2021
@Niilo007 Niilo007 added this to the SOS2 Compatibility milestone Sep 10, 2021
@Niilo007 Niilo007 added RT 2.5.15 RT Version 2.5.15 Confirmed This issue has been confirmed by a tester and will be passed on to programmers. labels Sep 10, 2021
@Niilo007 Niilo007 added this to Needs triage in RT Known Issues & Roadmap via automation Sep 10, 2021
@Niilo007 Niilo007 added this to Needs Triage in Mod Compatibility via automation Sep 10, 2021
@Niilo007 Niilo007 added this to Needs Triage in Testing To Do List via automation Sep 10, 2021
@Niilo007 Niilo007 added this to Needs Triage in Issue Categories via automation Sep 10, 2021
@Niilo007 Niilo007 moved this from Needs Triage to Tested / Closed in Testing To Do List Sep 10, 2021
@Niilo007 Niilo007 moved this from Needs triage to High priority in RT Known Issues & Roadmap Sep 10, 2021
@Niilo007 Niilo007 moved this from Needs Triage to Compatible / Unknown in Mod Compatibility Sep 10, 2021
@Niilo007 Niilo007 moved this from Needs Triage to Misc Issues in Issue Categories Sep 10, 2021
Sernior added a commit to Sernior/RimThreaded that referenced this issue Sep 11, 2021
@Sernior
-Fixed the infamous cseelhoff#639 cseelhoff#653
816a87a
@Niilo007 Niilo007 linked a pull request Sep 11, 2021 that will close this issue
Fixes issue #652 & #645 & #639 & #653 #657
Merged
RT Known Issues & Roadmap automation moved this from High priority to Solved / Closed Sep 11, 2021
Issue Categories automation moved this from Misc Issues to Closed Sep 11, 2021
cseelhoff added a commit that referenced this issue Sep 11, 2021
@cseelhoff
Merge pull request #657 from Sernior/2.5.14S
98e0cd2 
Fixes issue #652 & #645 & #639 & #653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working. Confirmed This issue has been confirmed by a tester and will be passed on to programmers. Reproducible This issue is reproducible. RT 2.5.15 RT Version 2.5.15 Vanilla RT This issue is reproducible when running only RimWorld, DLCs, Harmony, HugsLib & RimThreaded.
Projects
Issue Categories
Closed
Mod Compatibility
Compatible / Unknown
RT Known Issues & Roadmap
Solved / Closed
Testing To Do List
Tested / Closed
Milestone
SOS2 Compatibility
Development

Successfully merging a pull request may close this issue.

Fixes issue #652 & #645 & #639 & #653 Sernior/RimThreaded
2 participants
@Niilo007 @IK3Holy