httpserver: add URI matching #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daanklijn
approved these changes
Aug 4, 2020
| assert requests.get(httpserver.url_for("/foobar")).json() == {"foo": "bar"} | ||
| assert requests.get(httpserver.url_for("/foobaz")).json() == {"foo": "bar"} | ||
|
|
||
| assert requests.get(httpserver.url_for("/barfoo")).status_code == 500 |
There was a problem hiding this comment.
This means that the server has received an unexpected request and when I created the library I thought that it should be 500 and not 4xx as in this case the client did something not correctly and it should be the proper status (the client may handle the 404, but not the 500).
However, I would implement it again, probably 404 would be more correct as you suggested. But I don't want to break the API.
csernazs
force-pushed
the
wip-zsolt-urimatch
branch
from
5a1cb34
to
2947ff0
Compare
Extend URI matching functionality which now accepts: * a URIPattern object, whose match() method will be called * a compiled regexp returned by re.compile(). In this case the URI will be matched against the regexp. In both cases the URI will be an absolute path starting with a slash. Fixes #34 and #36.
csernazs
force-pushed
the
wip-zsolt-urimatch
branch
from
10d8826
to
882fe39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend URI matching functionality which now accepts:
URI will be matched against the regexp.
In both cases the URI will be an absolute path starting with a slash.
Fixes #34 and #36.