Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove nvim-treesitter dependency #35

Merged
merged 4 commits into from
Oct 14, 2023
Merged

Conversation

amaanq
Copy link
Contributor

@amaanq amaanq commented Oct 7, 2023

This will make the plugin solely depend on vim.treesitter which might need users to be on 0.9.0 at least - but in the near future nvim-treesitter will deprecate most of its plugin functionality and only serve as a parser installer, this PR will prepare for that. You can read about it more in the new main branch in nvim-treesitter

Do thoroughly go through it and critique is welcome, I also tidied up some of the code docs for types/function params

Copy link
Owner

@cshuaimin cshuaimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! I didn't know vim.treesitter can do ft -> lang translation.

Some nits:

  • you can use ts instead of vim.treesitter
  • vim.bo[buf].filetype instead of nvim_get_option_value()

lua/ssr.lua Show resolved Hide resolved
lua/ssr/utils.lua Outdated Show resolved Hide resolved
@amaanq amaanq changed the title refaactor!: remove nvim-treesitter dependency refactor!: remove nvim-treesitter dependency Oct 9, 2023
@cshuaimin
Copy link
Owner

Thank you again. I fixed the CI and parser check.

@amaanq
Copy link
Contributor Author

amaanq commented Oct 13, 2023

awesome, thanks!

@cshuaimin cshuaimin merged commit 10d51dd into cshuaimin:main Oct 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants