-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ffmpeg backend, thoughts? #85
Comments
Hi @gnat nice suggestions! I have actually had some thought on this for a while. This requires implementing the Imagor supports stacking multiple backend https://github.com/cshum/imagor/blob/master/imagor.go#L60 by logic. So on paper it should be possible to have ffmpeg backend that converts video to image, then pass to vips backend for all the fancy operations (resize, crop, watermark etc). Though of course adding a entirely new processing backend still requires significant amount of effort and understanding of ffmpeg. Another concern is the docker image size after ffmpeg is included, and how it should be packaged. But if anyone is willing to take an initiative on this, via a draft pull request, a separated package or anything similar, I am very keen to help out and collaborate :) |
@gnat check out imagorvideo! |
Lets redirect to the imagorvideo repo for further discussions: |
WOW! nice work @cshum 👑 |
really nice to have an example of such a major imagor extension too! |
So I've noticed Thumbor has https://github.com/theatlantic/thumbor-video-engine
Was wondering if @cshum has any thoughts on this, or if there is any ongoing effort to add ffmpeg as a backend (or something else that can do video, alongside vips) and/or what steps would be involved to do this?
Would be crazy useful to have the same basic interface with some different options for video.
Could just call whatever version of
ffmpeg
is on the host to Keep It Simple. 🤔Thanks and keep up the amazing work.
The text was updated successfully, but these errors were encountered: