controller/replication: add UnimplementedError for getVolRepInfo() #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
previously approved these changes
Feb 6, 2023
yati1998
requested changes
Feb 6, 2023
internal/util/error.go
Outdated
| @@ -28,3 +31,13 @@ func GetErrorMessage(err error) string { | |||
|
|
|||
| return s.Message() | |||
| } | |||
|
|
|||
| // IsUmplementedError returns true if the error is Unimplemented error. | |||
There was a problem hiding this comment.
IsUmplementedError-> IsUnimplementedError
This commit adds code to handle UnimplmentedError from getVolumeReplicationInfo rpc. The controller wil now ignore this error and not requeue the request. Fixes: csi-addons#236 Signed-off-by: Rakshith R <rar@redhat.com>
Rakshith-R
force-pushed
the
check-unimplemented-error
branch
from
ba70a84
to
8f2a31d
Compare
yati1998
approved these changes
Feb 7, 2023
Madhu-1
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds code to handle UnimplmentedError from getVolumeReplicationInfo rpc. The controller wil now ignore this error and not requeue the request.
Fixes: #236
Signed-off-by: Rakshith R rar@redhat.com