reclaimspace: add custom timeout support per CR #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpanic
reviewed
Jun 5, 2023
This commit adds support to specify timeout for reclaimspace operation in `reclaimspacejob.spec`. The time taken by reclaimspace operation on each PVC vary according to its size, data and io patterns. Therefore, each PVC may need a different timeout for this operation. Signed-off-by: Rakshith R <rar@redhat.com>
Rakshith-R
force-pushed
the
reclaimspace-timeout-CR
branch
from
b708a18
to
d812e4d
Compare
nixpanic
approved these changes
Jun 5, 2023
Madhu-1
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support to specify timeout for
reclaimspace operation in
reclaimspacejob.spec.The time taken by reclaimspace operation on each
PVC vary according to its size, data and io patterns.
Therefore, each PVC may need a different timeout
for this operation.
Resolves: #348