Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-56858 #82

Closed
wants to merge 1,458 commits into from
Closed

LPS-56858 #82

wants to merge 1,458 commits into from

Conversation

jorgediaz-lr
Copy link

Hi @csierra @mhan810

Since script console has been extracted to a OSGI bundle, we have some problems at groovy scripts:

  • It is not possible to import model classes at groovy scripts like "JournalArticle"
  • Service classes cannot be directly accessed, we have to use RegistryUtil

We can avoid all this issues adding DynamicImport-Package at portal-scripting OSGI bundles to be able to import classes of other OSGI modules.

See changes jorgediaz-lr@40cd495

@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED!

Build Time: 48 minutes 15 seconds

Job Results:

2 Jobs Passed.
3 Jobs Failed.

See the following links for more information.

  • test-portal-acceptance-pullrequest(master)/439

    Completed with the status of FAILURE.
  • test-portal-acceptance-pullrequest-backend(master)/349

    2 Failures.

  • test-portal-acceptance-pullrequest-plugins(master)/349

    2 Failures.

    • test-portal-acceptance-pullrequest-plugins(master) ?? 1,!test-1-8 #349
      compile:
      [mkdir] Created dir: /opt/dev/projects/github/liferay-plugins/dist
      [mkdir] Created dir: /opt/dev/projects/github/liferay-plugins/shared/portal-compat-shared/classes
      [copy] Copying 1 file to /opt/dev/projects/github/liferay-plugins/shared/portal-compat-shared/classes
      [jar] Building jar: /opt/dev/projects/github/liferay-plugins/dist/portal-compat-shared-7.0.0.1.jar
      [copy] Copying 1 file to /opt/dev/projects/github/liferay-plugins/shared/alloy-mvc-shared/lib
      [mkdir] Created dir: /opt/dev/projects/github/liferay-plugins/shared/alloy-mvc-shared/classes
      [copy] Copying 3 files to /opt/dev/projects/github/liferay-plugins/shared/alloy-mvc-shared/classes
      [copy] Copied 6 empty directories to 1 empty directory under /opt/dev/projects/github/liferay-plugins/shared/alloy-mvc-shared/classes
      [javac] Compiling 15 source files to /opt/dev/projects/github/liferay-plugins/shared/alloy-mvc-shared/classes
      [javac] /opt/dev/projects/github/liferay-plugins/shared/alloy-mvc-shared/src/com/liferay/alloy/mvc/BaseAlloyControllerImpl.java:628: error: incompatible types
      [javac] List<Indexer> indexerInstances = portletBag.getIndexerInstances();
      [javac] ^
      [javac] required: List<Indexer>
      [javac] found: List<Indexer<?>>
      [javac] Note: Some input files use or override a deprecated API.
      [javac] Note: Recompile with -Xlint:deprecation for details.
      [javac] Note: Some input files use unchecked or unsafe operations.
      [javac] Note: Recompile with -Xlint:unchecked for details.
      [javac] 1 error

      BUILD FAILED
      /opt/dev/projects/github/liferay-jenkins-ee/commands/build-test-portal-acceptance-pullrequest-plugins.xml:58: The following error occurred while executing this line:
      /opt/dev/projects/github/liferay-jenkins-ee/commands/build-test-portal-acceptance-pullrequest-plugins.xml:93: The following error occurred while executing this line:
      /opt/dev/projects/github/liferay-portal/build-test-plugins.xml:239: The following error occurred while executing this line:
      /opt/dev/projects/github/liferay-portal/build-test-plugins.xml:241: The following error occurred while executing this line:
      /opt/dev/projects/github/liferay-portal/build-test-plugins.xml:220: The following error occurred while executing this line:
      /opt/dev/projects/github/liferay-plugins/build-common.xml:3342: The following error occurred while executing this line:
      : The following error occurred while executing this line:
      /opt/dev/projects/github/liferay-plugins/build-common.xml:730: The following error occurred while executing this line:
      /opt/dev/projects/github/liferay-plugins/build-common.xml:994: Compile failed; see the compiler error output for details.
    • test-portal-acceptance-pullrequest-plugins(master) ?? 3,!test-1-8 #349
      compile-jsp:
      [mkdir] Created dir: /opt/dev/projects/github/liferay-plugins/dist
      [mkdir] Created dir: /opt/dev/projects/github/liferay-plugins/shared/portal-compat-shared/classes
      [copy] Copying 1 file to /opt/dev/projects/github/liferay-plugins/shared/portal-compat-shared/classes
      [jar] Building jar: /opt/dev/projects/github/liferay-plugins/dist/portal-compat-shared-7.0.0.1.jar
      [copy] Copying 1 file to /opt/dev/projects/github/liferay-plugins/portlets/ams-portlet/docroot/WEB-INF/lib
      [copy] Copying 1 file to /opt/dev/projects/github/liferay-plugins/shared/alloy-mvc-shared/lib
      [mkdir] Created dir: /opt/dev/projects/github/liferay-plugins/shared/alloy-mvc-shared/classes
      [copy] Copying 3 files to /opt/dev/projects/github/liferay-plugins/shared/alloy-mvc-shared/classes
      [copy] Copied 6 empty directories to 1 empty directory under /opt/dev/projects/github/liferay-plugins/shared/alloy-mvc-shared/classes
      [javac] Compiling 15 source files to /opt/dev/projects/github/liferay-plugins/shared/alloy-mvc-shared/classes
      [javac] /opt/dev/projects/github/liferay-plugins/shared/alloy-mvc-shared/src/com/liferay/alloy/mvc/BaseAlloyControllerImpl.java:628: error: incompatible types
      [javac] List<Indexer> indexerInstances = portletBag.getIndexerInstances();
      [javac] ^
      [javac] required: List<Indexer>
      [javac] found: List<Indexer<?>>
      [javac] Note: Some input files use or override a deprecated API.
      [javac] Note: Recompile with -Xlint:deprecation for details.
      [javac] Note: Some input files use unchecked or unsafe operations.
      [javac] Note: Recompile with -Xlint:unchecked for details.
      [javac] 1 error

      BUILD FAILED
      /opt/dev/projects/github/liferay-jenkins-ee/commands/build-test-portal-acceptance-pullrequest-plugins.xml:58: The following error occurred while executing this line:
      /opt/dev/projects/github/liferay-jenkins-ee/commands/build-test-portal-acceptance-pullrequest-plugins.xml:93: The following error occurred while executing this line:
      /opt/dev/projects/github/liferay-portal/build-test-plugins.xml:239: The following error occurred while executing this line:
      /opt/dev/projects/github/liferay-portal/build-test-plugins.xml:241: The following error occurred while executing this line:
      /opt/dev/projects/github/liferay-portal/build-test-plugins.xml:217: The following error occurred while executing this line:
      /opt/dev/projects/github/liferay-plugins/build-common-plugin.xml:652: The following error occurred while executing this line:
      : The following error occurred while executing this line:
      /opt/dev/projects/github/liferay-plugins/build-common.xml:686: The following error occurred while executing this line:
      /opt/dev/projects/github/liferay-plugins/build-common.xml:1017: The following error occurred while executing this line:
      : The following error occurred while executing this line:
      /opt/dev/projects/github/liferay-plugins/build-common.xml:804: The following error occurred while executing this line:
      /opt/dev/projects/github/liferay-plugins/build-common.xml:813: The following error occurred while executing this line:
      /opt/dev/projects/github/liferay-plugins/build-common.xml:852: The following error occurred while executing this line:
      : The following error occurred while executing this line:
      /opt/dev/projects/github/liferay-plugins/build-common.xml:1916: The following error occurred while executing this line:
      : The following error occurred while executing this line:
      /opt/dev/projects/github/liferay-plugins/build-common.xml:730: The following error occurred while executing this line:
      /opt/dev/projects/github/liferay-plugins/build-common.xml:994: Compile failed; see the compiler error output for details.
  • test-portal-acceptance-pullrequest-portalweb(master)/192

  • test-portal-acceptance-pullrequest-source(master)/436

@csierra
Copy link
Owner

csierra commented Jul 7, 2015

Just started reviewing :)

:octocat: Sent from GH.

@csierra
Copy link
Owner

csierra commented Jul 7, 2015

Pull request submitted to brianchandotcom#28006.

:octocat: Sent from GH.

@csierra csierra closed this Jul 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet