Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dedup of extracted rule candidates #87

Merged
merged 1 commit into from Feb 5, 2022
Merged

fix dedup of extracted rule candidates #87

merged 1 commit into from Feb 5, 2022

Conversation

keyan3
Copy link
Collaborator

@keyan3 keyan3 commented Feb 5, 2022

fixes #82. the previous deduplication code did not properly identify rules as duplicates of one another if the order of the antecedents was not identical.

@keyan3 keyan3 merged commit 2963cad into master Feb 5, 2022
@csinva csinva deleted the issue82 branch February 10, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The issue in ruleFit.get_rules(exclude_zero_coef=True).
1 participant