Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shorthand imports #95

Merged
merged 5 commits into from Aug 24, 2023
Merged

Remove shorthand imports #95

merged 5 commits into from Aug 24, 2023

Conversation

mx-moth
Copy link
Contributor

@mx-moth mx-moth commented Aug 24, 2023

I have a personal style preference for long hand imports like this.

@mx-moth mx-moth self-assigned this Aug 24, 2023
@mx-moth mx-moth merged commit 8291144 into main Aug 24, 2023
12 checks passed
@sharon-tickell
Copy link

Noted - what do you think about making a team style guide that has things like that listed?

@mx-moth
Copy link
Contributor Author

mx-moth commented Aug 24, 2023

I support a team style guide! I don't know whether I'd bother putting this in the style guide though. It seems very common to do import xarray as xr / import numpy as np in examples, notebooks, and scripts for some reason. It felt gross in a library. I can't really defend my preference enough to argue for its inclusion in a style guide.

@mx-moth mx-moth deleted the remove-shorthand-imports branch August 28, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants