Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing directories in fpa #1

Closed
robsyme opened this issue Jul 28, 2017 · 5 comments
Closed

Missing directories in fpa #1

robsyme opened this issue Jul 28, 2017 · 5 comments

Comments

@robsyme
Copy link

robsyme commented Jul 28, 2017

The fpa/Dockerfile at line #6 tries to copy fp_app_api into the docker image:

COPY fp_app_api /app/fp_app_api

The same problem occurs on line #22 with the sslStuff directory:

COPY sslStuff /app/sslStuff

The problem is that the fp_app_api and sslStuff directories don't seem to exist in the repository. Are these built elsewhere?

@robsyme robsyme changed the title Missing fp_app_api directory Missing directories in fpa Jul 28, 2017
@alexwhan
Copy link
Member

alexwhan commented Aug 3, 2017

@taerwin could you have a look at this?

@taerwin
Copy link
Collaborator

taerwin commented Aug 4, 2017

@robsyme sslStuff will need to be created outside of docker as it contains the ssl certificate files (server.crt, server.key) required by apache/flask if you want to run fieldprime in a production mode. I will add some documentation about this.

fp_app_api is no longer used and should be removed. I will add a fix.

@robsyme
Copy link
Author

robsyme commented Aug 4, 2017

I thought that might be the case for sslStuff, but it's good to know I've not done something dumb to be missing fp_app_api.

@taerwin
Copy link
Collaborator

taerwin commented Aug 7, 2017

I have cleaned up the Dockerfile(s) and added an empty sslCerts directory where ssl certificates will need to be placed to use https.

@taerwin taerwin closed this as completed Aug 7, 2017
@robsyme
Copy link
Author

robsyme commented Aug 7, 2017

Thanks taerwin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants