Python 2.7 fix #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cslashm
reviewed
Jul 16, 2019
There was a problem hiding this comment.
Please let's try my proposition (see review and update your PR if OK
It minimize the modification
Moreover do not close/open new PR at each mods when you PR .
Create a branch (let's Py2.7Fix). PR from this branch and update your branch with review/comment....PR is automagically updated
Else review and conversation are lost.
About rfc6979 (I know it), do you use it with ecschnorr? and If possible it better to make different PR for different subject.
sign_rfc6979 removed _do_sign improvement : size parameter added when returning encode_sig allowing direct use of RAW and EDDSA signature format
|
Hi, |
autodefine size for RAW and EDDSA signature if size not provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR following #8 discution.