Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Tutorial mentioned in README.md has moved #258

Closed
jimorc opened this issue Jan 24, 2019 · 3 comments
Closed

Basic Tutorial mentioned in README.md has moved #258

jimorc opened this issue Jan 24, 2019 · 3 comments
Assignees
Milestone

Comments

@jimorc
Copy link
Contributor

jimorc commented Jan 24, 2019

The basic tutorial that you mentioned in README.md has been updated and moved to https://computingonplains.wordpress.com/google-test-and-visual-studio/

@jimorc
Copy link
Contributor Author

jimorc commented Jan 24, 2019

I created a pull request. This is the first time I have done that and of course I managed to mess it up. The only required change is the one in README.md, but I don't know how to go back and remove the others.

@csoltenborn
Copy link
Owner

Thanks for letting me know! 👍

And the good news is that you have not yet created a pull request (PR). You have so far only cloned my repository and committed the fix into your cloned repository, but a PR has not yet happened.

Now, I can of course do that change for myself, but if you want to learn about PRs (and see your name in the history of this repository), then feel free to do a second try:

  • Create a branch on your repository (e.g. documentation_fixes) and check out that branch
  • Fix the issue on your repository and commit your fix
  • Go to the Pull Requests tab and create a new PR
  • Choose my repository's master branch as base (usually this would be the develop branch, but since this is documentation "only", I think it's fine to go for the master branch)
  • Check out whether the changes contained in your PR are as desired (check out the "Files changed" section)
  • Submit your PR

I will then review and pull in your changes. Let me know if you need more help - the first PR is rather challenging, as I know from my own experience :-)

One last note: While you are at it, would you mind to also fix the other broken links mentioned in #257?

@csoltenborn
Copy link
Owner

Solved with #259

@csoltenborn csoltenborn added this to the 0.14.3 milestone Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants