Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTA does not detect VS2019 16.1 Preview #286

Closed
trkrogstad opened this issue May 2, 2019 · 4 comments
Closed

GTA does not detect VS2019 16.1 Preview #286

trkrogstad opened this issue May 2, 2019 · 4 comments
Assignees
Milestone

Comments

@trkrogstad
Copy link

The vsix-installer does not seem to detect VS2019 16.1 Preview 2.0. Could it be some version number expectation? GTA is not present in the "Manage Extension"-plugin when searching the online Marketplace either, which I guess could be related. Probably a quick change of the vsixmanifest is sufficient: https://devblogs.microsoft.com/visualstudio/how-to-upgrade-extensions-to-support-visual-studio-2019/

@csoltenborn
Copy link
Owner

Interesting... I had increased the target version (otherwise GTA would not be able to install into VS2019 at all). However, I have realized the changes as suggested by your link (thanks!) within this version - would you mind to give it a try?

@trkrogstad
Copy link
Author

I can confirm that the version you linked to in the previous post detects 2015, 2017, and 2019 preview 2.0 when running the vsix. So it seems to fix the problem.

@csoltenborn
Copy link
Owner

Ok, thanks! Will probably release an update at the weekend...

@csoltenborn csoltenborn self-assigned this May 4, 2019
@csoltenborn csoltenborn added this to the 0.16.1 milestone May 4, 2019
@csoltenborn
Copy link
Owner

Fixed with PR #287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants