-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for visibility distance/barometric pressure conversion units #338
Conversation
Hi @Darumin so far it looks nice, thanks! A couple of improvements: One - As you've already coded the core conversion logic, I would now advice to expose it through new methods of the def wind(self, unit='meters_sec'):
... Something like: def pressure(self, unit='hPa'):
...
def visibility_distance(self, unit='m'):
... Please, only make sure that the provided default units are from the International Decimal Metric System (m & Pa) Two - In order to let the world know and use your excellent work, why don't you also update the technical docs here and the quick code recipes Thanks a lot! |
I added the matching methods to You'll also see new recipes and utilities usage examples, as requested. Let me know if there's anything else that needs clarity. |
Hello @Darumin thanks for the contribution, it's on the |
@csparpa This doesn't seem to have actually been merged? Also of note, there's technically a breaking change here, with |
@Harmon758 I probably have messed the merge up on my local setup :-S |
@Darumin @Harmon758 I've merged this. As the newly introduced Now the funciton is called |
Attempt to fulfill #325 by adding conversions in measurables.py for pressure ("Hg) and visibility (kms/miles), also added unit tests to go with them.