-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add history file support #24
Conversation
This functions as best I can work out, but the configuration needs an absolute location for the history file. The config file does not interpret ${HOME} or ~, which might need discussion. For issue cspeterson#23
91ff7e8
to
76bca85
Compare
The history file will now default to ~/.local/state/splatmoji/history as per XDG proposal for such things. The tilde is expanded to ${HOME} when reading the config. This expansion will occur for every variable, as long as the tilde occurs at the start of the variable value. I don't see this causing any issues, and could be useful if you have either menu or typing tools in ~/bin/
I like it! I read the discussion in #23, and welcome this PR generally, but I'm not sure if
rofi itself uses There also was some discussion in rofi/#747 to use rofi's built-in history mechanism for custom scripts, but that has been rejected for |
@iFreilicht It may be helpful to skim through #23, the associated bug, as that's where I got the |
Yes, that's what I did :) Maybe @cspeterson can comment on this, `.local/state` was his proposal after all.
22 Sep 2020 00:21:01 William Pettersson <notifications@github.com>:
… @iFreilicht[https://github.com/iFreilicht] It may be helpful to skim through #23[#23], the associated bug, as that's where I got the ~/.local/state/splatmoji location from. I admit, I don't know the XDG spec well enough to make such a decision, but it's easy to change.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub[#24 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ACKKSK5S7W4YAGNA7MVRVNTSG7GUVANCNFSM4RKB6UYA]. [https://github.com/notifications/beacon/ACKKSKYXT545AXZVKSW6PS3SG7GUVA5CNFSM4RKB6UYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFGBF3PY.gif]
|
Okay so first considering only the "where does the recent selection list live" question... 😁 Where my suggestion came fromMy suggestion of
I agree with the maillist conversation there that there is a need for something distinct from "cache" and I think the proposed location is reasonable and I know no better or more standard answer. So if I'm actually the decider (I guess I am!?! 😅) I suppose that's the answer and I see no requirement for it to be configurable unless someone convinces me otherwise |
Huh, that's very interesting, I had no idea. You are indeed the person to decide, this is your project after all :) And hey, if enough projects start using |
@WPettersson And then for the rest of it: thanks so much for doing the work! I'll take a closer look soon and am delighted to have the new feature |
Okay I roped in the new code and adjusted/added tests. Thanks! |
This functions as best I can work out, but the configuration needs an
absolute location for the history file. The config file does not
interpret ${HOME} or ~, which might need discussion.
This is for issue #23