Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use workspace deps for casper related crates #122

Merged
merged 7 commits into from
Jun 18, 2024
Merged

Use workspace deps for casper related crates #122

merged 7 commits into from
Jun 18, 2024

Conversation

marijanp
Copy link
Collaborator

No description provided.

@marijanp marijanp self-assigned this Jun 13, 2024
Cargo.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@koxu1996 koxu1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marijanp I analyzed usage of casper-* dependencies and found 2 missed cases - suggestions added.


Extra notes from my review:

Old casper-types

We were using old casper types in 3 places:

kairos-cli/Cargo.toml:22:casper-types = { version = "3", features = ["std"] } # TODO: Change `std` -> `std-fs-io` in the future version.
kairos-server/Cargo.toml:50:casper-types = "3"
kairos-contracts/demo-contract/contract-utils/Cargo.toml:8:casper-types = { version = "3", default-features = false }

This PR replaced first two with the common casper-client-types = { package = "casper-types", version = "3.0" }, which is good, just a bit of renaming. However, contract-utils was upgraded to types 4.0, which is okay too, because we were using old types without valid reason.

So now we are using old types in 2 places: kairos-cli and kairos-server. I will do some cleanup later, as we can reduce it to single usage.

casper-* dependencies with a single usage

Test crates:

demo-contract-tests/Cargo.toml:8:casper-engine-test-support = { version = "7.0.0", default-features = false }
demo-contract-tests/Cargo.toml:9:casper-execution-engine = { version = "7.0.0", default-features = false }

CES toolkit:

kairos-server/Cargo.toml:43:casper-event-toolkit = { git = "https://github.com/koxu1996/casper-event-toolkit.git", version = "0.1.3" }

Co-authored-by: koxu1996 <andrzej1_1@o2.pl>
@marijanp marijanp requested a review from koxu1996 June 18, 2024 14:03
Cargo.toml Outdated Show resolved Hide resolved
@koxu1996 koxu1996 merged commit e860339 into main Jun 18, 2024
4 checks passed
@koxu1996 koxu1996 deleted the workspace-deps branch June 18, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants