Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate ASN.1 transaction format with server #53

Merged
merged 10 commits into from
Mar 27, 2024
Merged

Integrate ASN.1 transaction format with server #53

merged 10 commits into from
Mar 27, 2024

Conversation

koxu1996
Copy link
Contributor

@koxu1996 koxu1996 commented Mar 26, 2024 •
edited
Loading

This PR integrates deterministic transaction format (introduced in #30) - with Kairos server.

Notes

  1. Error handling could be better, but blocked by Move to thiserror so we can consume typed JSON errors in the CLI. #10.
  2. Signature verification will be integrated once Signer module - kairos-crypto #35 is merged.

@koxu1996 koxu1996 self-assigned this Mar 26, 2024
@koxu1996 koxu1996 marked this pull request as ready for review March 26, 2024 14:29
Avi-D-coder
Avi-D-coder approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@Avi-D-coder Avi-D-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Rom3dius
Rom3dius approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@Rom3dius Rom3dius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes TODOs, therefore its good.
All jokes aside, this also looks good to me.

@koxu1996 koxu1996 merged commit dca516f into main Mar 27, 2024
6 checks passed
@koxu1996 koxu1996 deleted the feature/integrate-tx-with-server branch March 28, 2024 12:35
@koxu1996 koxu1996 mentioned this pull request Apr 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avi-D-coder Avi-D-coder Avi-D-coder approved these changes

@Rom3dius Rom3dius Rom3dius approved these changes

@marijanp marijanp Awaiting requested review from marijanp

@jonas089 jonas089 Awaiting requested review from jonas089

Assignees

@koxu1996 koxu1996

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@koxu1996 @Avi-D-coder @Rom3dius