Predictable imports order

[sullenor]

A small attempt of mine to make a proper dependency resolution for the case #131:

.a {
  composes: c from './c.css';
}

.b {
  composes: b from './b.css';
  composes: c from './c.css';
}

[codecov-io]

Codecov Report

Merging #138 into master will increase coverage by 1.99%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   91.56%   93.56%   +1.99%     
==========================================
  Files           2        4       +2     
  Lines          83      233     +150     
  Branches       20       46      +26     
==========================================
+ Hits           76      218     +142     
- Misses          7       15       +8

Impacted Files	Coverage Δ
src/topologicalSort.js	100% <100%> (ø)
src/index.js	92.3% <91.66%> (-7.7%)	⬇️
lib/topologicalSort.js	97.05% <0%> (ø)
lib/index.js	91.2% <0%> (+5.79%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2c40a2...ed63ddc. Read the comment docs.

[sullenor]

@geelen @markdalgleish @sokra @joshwnj in case you have some time, please, take a look into it. Since this module is commonly used, the changes can be a bit breaking for the existing projects :)

thanks

[sullenor]

Not sure about the option's name failOnWrongOrder. In case you have a better variant — tell me.

The purpose of it is to warn a user if he made a dependency order which isn't possible to resolve properly:

.a {
  composes: aa from './aa.css';
  composes: bb from './bb.css';
}

.b {
  composes: bb from './bb.css';
  composes: aa from './aa.css';
}

[sullenor]

Up!

[tivac]

Not that it matters but a huge 👍 from me, adding a dependency graph to imports in modular-css was super valuable.

[sullenor]

I hope that smone can ship it since I don't any permission to publish the package

[geelen]

This looks fine to me. I am a little worried that it might very subtly break the resulting CSS for some existing users, so I think it might make sense to publish this under a dist-tag to give it some real-world testing before turning it on for everyone?

[sullenor]

dist-tag would be fine