fix: className conflict to keyword like constuctor or toString #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 1
Lines ? 103
Branches ? 24
=======================================
Hits ? 103
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Nov 9, 2018
|
@evilebottnawi can you release a patch version? |
|
@jerry-i hm, how we can test this? |
|
@evilebottnawi I have add one test case for it. And you can see the erorr case online. |
|
@jerry-i thanks will be released in patch version in near future |
src/index.js
Outdated
| @@ -58,7 +58,8 @@ const processor = postcss.plugin('postcss-modules-scope', function(options) { | |||
| const generateScopedName = | |||
| (options && options.generateScopedName) || processor.generateScopedName; | |||
|
|
|||
| const exports = {}; | |||
| let exports = Object.create(null); | |||
| // let exports = {}; | |||
There was a problem hiding this comment.
Remove comment, and why don't use const?
|
麻烦大佬合下代码！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third part lib like
monaco-editorhas the css selector name like .constructor which conflict withObject's keywords.😂