Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scoped class attribute #30

Merged
merged 2 commits into from
Dec 21, 2023
Merged

fix: scoped class attribute #30

merged 2 commits into from
Dec 21, 2023

Conversation

TheSTL
Copy link
Contributor

@TheSTL TheSTL commented May 1, 2021

Fixed css-loader-issue-1286

Scoped only class attribute with = operator.

@TheSTL TheSTL force-pushed the fix-class-attribute branch 3 times, most recently from 3a05d8d to 2cb2e61 Compare May 1, 2021 18:37
alexander-akait
alexander-akait reviewed May 18, 2023
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for very long delay, do you want to finish it? We need ignore any things expect class, so let's add more tests

@TheSTL
Copy link
Contributor Author

TheSTL commented Sep 14, 2023

I have added more test cases. Can you please check now? @alexander-akait

@alexander-akait alexander-akait merged commit ab8d7a1 into css-modules:master Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] CSS attribute selectors classnames aren't being generated as expected
2 participants
@TheSTL @alexander-akait