Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows sourcemap paths. #12

Closed
wants to merge 1 commit into from
Closed

Fix Windows sourcemap paths. #12

wants to merge 1 commit into from

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Dec 12, 2018

Refs #7.

/CC @lahmatiy

@XhmikosR
Copy link
Contributor Author

Ping @lahmatiy. There's also twbs/bootstrap#27811 (comment)

@lahmatiy
Copy link
Member

Sorry for delay with response. I fixed problem by myself since it has one more issue to fix (see d162d06).
Thank you!

@lahmatiy lahmatiy closed this Dec 26, 2018
@XhmikosR XhmikosR deleted the patch-3 branch December 26, 2018 15:01
@XhmikosR
Copy link
Contributor Author

NP, I'll test it out in the next release :)

@lahmatiy
Copy link
Member

Published as 2.0.1 (https://github.com/css/csso-cli/releases/tag/v2.0.1)

@XhmikosR
Copy link
Contributor Author

@lahmatiy: the slashes issue is fixed. But I still see another issue in Bootstrap, see my comment twbs/bootstrap#27811 (comment)

@XhmikosR
Copy link
Contributor Author

Maybe it's not a bug, I don't know, but I couldn't get your attention in the PR.

@lahmatiy
Copy link
Member

@XhmikosR Sorry, I thought the PR is about paths issue, therefore I did not look deeper. Will take a look!

@XhmikosR
Copy link
Contributor Author

@lahmatiy: NP, and thanks for taking a look. BTW I was wondering, why doesn't csso expose the source map API so that we don't reinvent the wheel here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants