fix wrong descendant combinator removal (fixes #246)

css · Oct 20, 2015 · dd8709e · dd8709e
1 parent b2ecb59
commit dd8709e
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/lib/compressor/index.js b/lib/compressor/index.js
@@ -413,7 +413,12 @@ CSSOCompressor.prototype.cleanWhitespace = function(token, rule, parent, i) {
     if (nextType === 'unknown') {
         token[2] = '\n';
     } else {
-        if ((parentType !== 'atrulerq' || prevType) &&
+        if (parentType === 'simpleselector') {
+            if (!prevType || prevType === 'combinator' ||
+                !nextType || nextType === 'combinator') {
+                return null;
+            }
+        } else if ((parentType !== 'atrulerq' || prevType) &&
             !this.issue16(prevType, nextType) &&
             !this.issue165(parent, prevType, nextType) &&
             !this.issue134(prevType, nextType) &&

diff --git a/test/fixture/compress/selector/1.css b/test/fixture/compress/selector/1.css
@@ -0,0 +1,14 @@
+/*
+  issue #246:
+  shouldn't remove descendant combinator
+*/
+
+div.dropdown * {
+  color: #ff0000;
+}
+* div {
+  color: blue;
+}
+a  b {
+  color: green;
+}
diff --git a/test/fixture/compress/selector/1.min.css b/test/fixture/compress/selector/1.min.css
@@ -0,0 +1 @@
+div.dropdown *{color:red}* div{color:#00f}a b{color:green}