Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EchoSVG depends on Apache FOP which in recent versions depends on Batik #10

Closed
carlosame opened this issue Apr 15, 2021 · 2 comments
Closed
Labels
bug Something isn't working
Milestone

Comments

@carlosame
Copy link
Member

carlosame commented Apr 15, 2021

The echosvg-rasterizer and related modules introduce a dependency on Apache FOP, which in recent versions depends on Batik. The original Batik code worked around the issue by including a 2.3-SNAPSHOT binary of FOP in the lib directory, but that's really ugly.

This issue tracks the removal of the rasterizer module and related files, as well as dropping the support for PDF images in the svgrasterizer app.

@carlosame carlosame added the bug Something isn't working label Apr 15, 2021
carlosame added a commit that referenced this issue Apr 15, 2021
@ghost
Copy link

ghost commented Apr 17, 2021

Another possibility would be to import the relevant FOP sources. They import the binaries, we import the sources :-)

For my particular case, FOP would not be needed, so hopefully there's a way to prevent including the dependency. When generating a PDF, my app invokes ConTeXt, which then handles conversion of SVG to METAPOST statements, which are then exported to PDF.

carlosame added a commit that referenced this issue Apr 19, 2021
@carlosame
Copy link
Member Author

This issue should now be solved, and I added the relevant text to MIGRATING_FROM_BATIK. In case that a bug related to PDF images remains around, a new issue should be opened.

@carlosame carlosame added this to the 0.1 milestone Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant