bridge: replace the WeakReference in SVGAnimationEngine with a SoftReference
#104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ine` with a `SoftReference` In `SVGAnimationEngine` the animation engine is kept as a `WeakReference`, but with the current JVMs those references do not last very long. This may cause some animations to not happen. Also due to that, the `SwingMemoryLeakTest` requires at least 4GB of heap space to pass and is triggering failures. Switching the `WeakReference` by a `SoftReference` may seem a bit radical but is the most conservative way to fix this. As a consequence of this change, the stress-tests for `WeakReference`d objects (that were failing, as explained above) are no longer executed during the build. It could be said that such tests achieved what they were intended for: check for the validity of the `WeakReference` approach. Closes #103.
|
This change was reverted today, as further experimentation did not gave good results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
SVGAnimationEnginethe animation engine is kept as aWeakReference, but with the current JVMs those references do not last very long. This may cause some animations to not happen.Also due to that, the
SwingMemoryLeakTestrequires at least 4GB of heap space to pass and is triggering failures. Switching theWeakReferenceby aSoftReferencemay seem a bit radical but is the most conservative way to fix this.As a consequence of this change, the stress-tests for
WeakReference-d objects (that were failing, as explained above) are no longer executed during the build. It could be said that such tests achieved what they were intended for: check for the validity of theWeakReferenceapproach.Closes #103.