Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve lint option reporting #245

Closed
necolas opened this issue Jun 23, 2014 · 14 comments
Closed

Improve lint option reporting #245

necolas opened this issue Jun 23, 2014 · 14 comments

Comments

@necolas
Copy link
Contributor

necolas commented Jun 23, 2014

Would be good for the --lint option to output line:column information about where there are problems, and what the issue is. At the moment it only tells you which files have issues but leaves you to hunt them down.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/2790110-improve-lint-option-reporting?utm_campaign=plugin&utm_content=tracker%2F214563&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F214563&utm_medium=issues&utm_source=github).
@necolas
Copy link
Contributor Author

necolas commented Aug 26, 2014

To add a bit more detail…

Reporting the line and failure would be a great first step for the "lint" option.
Eventually something approaching jscs' great reporting would be fantastic:

It also provides public methods to do things with the errors (useful for plugins): https://github.com/sindresorhus/gulp-jscs/blob/d0db3c7552491c634d975566228ea0d3479abd93/index.js#L39-L40

@lkrids
Copy link

lkrids commented Sep 1, 2014

+1

@necolas
Copy link
Contributor Author

necolas commented Sep 1, 2014

Also requesting that the lint feature be available in the node.js API (if it is already I couldn't find documentation).

@spinus
Copy link

spinus commented Sep 5, 2014

+1

1 similar comment
@AntonTrollback
Copy link

+1

@vecmezoni vecmezoni mentioned this issue Sep 13, 2014
@ismay
Copy link

ismay commented Oct 8, 2014

+1

@necolas
Copy link
Contributor Author

necolas commented Oct 9, 2014

Any update on this? What about just adding line number and type of error rather than waiting for patches to gonzales.

@lkrids
Copy link

lkrids commented Dec 9, 2014

+1

@ismay
Copy link

ismay commented May 28, 2015

@tonyganch Since this issue is already pretty old, and a lot of people are looking forward to the feature, I was wondering if there's a specific timeframe for the 3.2 release (and the improved linting)? Right now there's no date specified.

It's been a while, and necolas has already closed his issue regarding csscombs linting because of the inactivity. Any specific issues that are holding this back, or is it a lack of available time? I'm still hoping that we can move this forward! It would be a shame for csscomb to be abandoned.

@MoOx
Copy link

MoOx commented May 28, 2015

If you are looking for some linting, you should take a look to stylelint which is (thanks to @DavidClark) taking a really good shape ! https://github.com/stylelint/stylelint/tree/master/src/rules

@ismay
Copy link

ismay commented May 28, 2015

@MoOx Ah, that looks like a very good alternative, thanks!

@MoOx
Copy link

MoOx commented May 28, 2015

No release yet, but one will be here really soon !

@tonyganch
Copy link
Member

It's lack of time now only.
The issue did depend on some work with parser which i've (hopefully) finished this week.
Now the order of issues to close is following:

  • Add lint methods to api (like lintFile and lintString)
  • Add lint methods to current options so they return a list of found errors
  • Format error messages to display them nicely in terminal

It'll take some more time but i'm working on it.
As for version number, i think it'll actually be 4.0 (skipping 3.2) because of some backwards incompatibilities. ETA is mid of summer.

@ismay
Copy link

ismay commented May 28, 2015

@tonyganch Cool, that's good to know. Thanks for the quick reply!

@tonyganch tonyganch removed this from the 4.0 milestone Jul 11, 2016
@necolas necolas closed this as completed Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants